# HG changeset patch # User Dan # Date 1256443751 14400 # Node ID adfbe522c95f8d1ab265544fb4ae86c432e59bf4 # Parent c308b471ed82f9a85181413e0447361b9c98a894 Another fix to paragraph bypass behavior, for when the same substring appears more than once in the text diff -r c308b471ed82 -r adfbe522c95f includes/wikiengine/parse_mediawiki.php --- a/includes/wikiengine/parse_mediawiki.php Tue Oct 13 12:44:27 2009 -0400 +++ b/includes/wikiengine/parse_mediawiki.php Sun Oct 25 00:09:11 2009 -0400 @@ -209,14 +209,32 @@ // using preg_replace here sometimes gives us empty strings probably because we're using $0 // in the replace formatter. so we'll just take care of it explicitly here with preg_match_all // and good ole str_replace_once. + + // FIXME this regexp can cause crashes under win32 PHP due to some apache limitations... possibly + // write a non-regexp based replacement. same bug as the comment block above, apparently + + // oh. and we're using this tokens thing because for identical matches, the first match will + // get wrapped X number of times instead of all matches getting wrapped once; replacing each + // with a unique token id remedies this + + $tokens = array(); + $rand_id = sha1(microtime() . mt_rand()); if ( preg_match_all($regex, $text, $matches) ) { - foreach ( $matches[0] as $match ) + foreach ( $matches[0] as $i => $match ) { - $text = str_replace_once($match, '<_paragraph_bypass>' . $match . '', $text); + $text = str_replace_once($match, "{_pb_:$rand_id:$i}", $text); + $tokens[$i] = '<_paragraph_bypass>' . $match . ''; } } + foreach ( $tokens as $i => $match ) + { + $text = str_replace_once("{_pb_:$rand_id:$i}", $match, $text); + } + + // die('
' . htmlspecialchars($text) . ''); + RenderMan::tag_unstrip('_paragraph_bypass', $text, $_nw, true); // This is potentially a hack. It allows the parser to stick in <_paragraph_bypass> tags